build: move from angular-cli to gulp #948
Conversation
googlebot
added
cla: yes
hansl
force-pushed
the
gulp-build
branch
5 times, most recently
from
f2bc3ad
to
957b53e
Compare
|
Please, share the reasons behind moving to gulp build. Are you willing to stay with Systemjs or cli is very unstable now? |
|
@RemKolomna CLI is moving to WebPack, and as much as it pains me, it's not suitable for libraries (yet). We'll come back to using it when it does. |
hansl
force-pushed
the
gulp-build
branch
2 times, most recently
from
6ede3f8
to
48627ea
Compare
|
@hansl glad to know they're going to use webpack Mind to share with us why you believe webpack isn't suitable for libraries yet? Just curious... |
|
I don't think this PR is the right place for this discussion so I'll be short; Angular-CLI is not suitable for libraries (yet). Webpack is suitable for apps, not libraries, because it's not meant to output files that will be published to npm. It's meant to bundle/pack files that will be served. I might move our demo-app serving and building to webpack though as it's faster than what we have here, but for now this fills my current set of goals to not be dependent on the CLI. |
hansl
force-pushed
the
gulp-build
branch
7 times, most recently
from
5b3ba78
to
b6f11e4
Compare
hansl
force-pushed
the
gulp-build
branch
8 times, most recently
from
225906e
to
c6858c8
Compare
|
@jelbourn: Ready for a second pass, and you'll love it; I added a |
| 'use strict'; | ||
| const path = require('path'); | ||
|
|
||
|
|
There was a problem hiding this comment.
Add a comment here pointing people to the appropriate location for the tasks?
| @@ -13,14 +13,13 @@ const config = { | |||
| useAllAngular2AppRoots: true, | |||
| specs: [ path.join(__dirname, '../e2e/**/*.e2e.ts') ], | |||
| baseUrl: E2E_BASE_URL, | |||
| allScriptsTimeout: 30000, | |||
| getPageTimeout: 30000, | |||
| allScriptsTimeout: 120000, | |||
There was a problem hiding this comment.
Should we have a TODO to lower this back down?
There was a problem hiding this comment.
We'll only have more tests, so I don't see a future where this will go down significantly.
|
LGTM aside from last few comments |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.